Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pango, cairo to v0.18 #560

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

flxzt
Copy link
Contributor

@flxzt flxzt commented Jul 24, 2023

A new pango and cairo release is out, the changelog can be found here. There are no changes in the API that are used by piet as far as I can tell.

Can there be a new piet release at some point? The last one is using cairo v0.16 .

@xStrom
Copy link
Member

xStrom commented Jul 24, 2023

I can merge if you also solve the unrelated clippy errors.

Error:    --> piet-web/src/lib.rs:547:13
    |
547 |         let mut canvas_state = self.canvas_states.last_mut().unwrap();
    |             ----^^^^^^^^^^^^
    |             |
    |             help: remove this `mut`

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

As for making a release, it certainly makes sense to do a new release at some point this year. Making it just for this dependency update seems bit of an overkill, so I'll see if there's a few other PRs that could be merged as well.

@xStrom xStrom merged commit 303b9a9 into linebender:master Jul 24, 2023
15 of 16 checks passed
@flxzt flxzt deleted the bump-cairo-v-0-18 branch July 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants