Skip to content

Commit

Permalink
Fix Witty export of functions with 16 parameters (#2429)
Browse files Browse the repository at this point in the history
* Refactor to use `HList!` macro

Instead of manually creating the very deeply nested type.

* Update `wasmtime` to include 17 parameters fix

Allow usage of 17 parameters with typed exported functions.

* Don't lower parameters laid out in 16 flat types

Keep them as flat parameters instead, even if the return type needs to
be lowered as well.

* Remove dummy arguments in WIT interface

They were added to work-around the issue with function parameters that
flattened to 16 flat types, and with the fix they are no longer needed.

* Add a TODO to use a proper released version

Instead of pinning to the commit with the necessary fix.
  • Loading branch information
jvff authored Aug 31, 2024
1 parent b710503 commit be15a4c
Show file tree
Hide file tree
Showing 14 changed files with 209 additions and 318 deletions.
221 changes: 93 additions & 128 deletions Cargo.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ wasm-instrument = "0.4.0"
wasmer = { package = "linera-wasmer", version = "4.3.6-linera.3", default-features = false }
wasmer-compiler-singlepass = { package = "linera-wasmer-compiler-singlepass", version = "4.3.6-linera.3" }
wasmparser = "0.101.1"
wasmtime = "24.0.0"
# TODO(#2430): use the latest release of Wasmtime that includes the commit referenced below
wasmtime = { git = "https://github.com/bytecodealliance/wasmtime", rev = "58f82587462543e912b4edcbb247842711ba6415" }
wasmtimer = "0.2.0"
webassembly-test = "0.1.0"
web-sys = "0.3.69"
Expand Down
Loading

0 comments on commit be15a4c

Please sign in to comment.