Ensure only data blobs are present in SDK/System API calls #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
andresilva91
force-pushed
the
08-08-ensure_only_data_blobs_are_present_in_sdk_system_api_calls
branch
4 times, most recently
from
6786837
to
75d46ce
Compare
graphite-app
bot
requested review from
ma2bd,
jvff,
MathieuDutSik,
christos-h,
Twey and
afck
and removed request for
ma2bd
Graphite Automations"Assign reviewers" took an action on this PR • (08/13/24)6 reviewers were added to this PR based on Andre da Silva's automation. |
afck
approved these changes
Aug 13, 2024
andresilva91
force-pushed
the
08-08-ensure_only_data_blobs_are_present_in_sdk_system_api_calls
branch
from
75d46ce
to
6d58848
Compare
afck
approved these changes
Aug 13, 2024
Merge activity
|
andresilva91
deleted the
08-08-ensure_only_data_blobs_are_present_in_sdk_system_api_calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't want
BlobIdexposed to the SDK. Users will only be aware ofDatablobs, the other types will be only internally used.Proposal
Only expose
Datablobs to the SDK, and assume when dealing with blobs that it's aDatablob. Because of that we don't need to useBlobIdeverywhere, and can just use the hash of theDatablob in most places.Test Plan
CI + also retested the NFT UI