ChainStateView::execute_block can now activate a chain. #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvff
approved these changes
Aug 15, 2024
linera-chain/src/chain.rs
Outdated
| return Err(ChainError::InactiveChain(chain_id)); | ||
| }; | ||
| let Some(posted_message) = in_bundle.bundle.messages.first().filter(|pm| { | ||
| println!("{:#?}", pm.message); |
There was a problem hiding this comment.
I guess this println! should be removed? (Or replaced with trace!?)
There was a problem hiding this comment.
Sorry, too much debugging today! 🤦
| .map_or(true, |description| description.is_child()) | ||
| { | ||
| ensure!( | ||
| block.starts_with_open_chain(), |
There was a problem hiding this comment.
Is this helper method still used after this change?
There was a problem hiding this comment.
Good catch, I'll remove it!
afck
force-pushed
the
execute-block-open-chain
branch
from
20a52a8
to
00a8627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The linera-sdk
TestValidatordirectly callsexecute_block, without first handling the immediate message. That currently fails if it's the first block of a new child chain, because it has not been initialized yet.Proposal
In
execute_block, if it's block 0 of a child chain and the first message isOpenChain, execute that message before doing anything that requires the chain to be active.Test Plan
CI should catch any regressions.
The feature itself was tested locally and will be used soon when the hex-game is extended to automatically create temporary chains.
Links