Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Witty export of functions with 16 parameters #2429

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Fix Witty export of functions with 16 parameters #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3a8e20
Refactor to use `HList!` macro
jvff Aug 22, 2024
93e1f64
Update `wasmtime` to include 17 parameters fix
jvff Aug 30, 2024
25f9229
Don't lower parameters laid out in 16 flat types
jvff Aug 23, 2024
e502be5
Remove dummy arguments in WIT interface
jvff Aug 30, 2024
9b433f6
Add a TODO to use a proper released version
jvff Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
221 changes: 93 additions & 128 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ wasm-instrument = "0.4.0"
wasmer = { package = "linera-wasmer", version = "4.3.6-linera.3", default-features = false }
wasmer-compiler-singlepass = { package = "linera-wasmer-compiler-singlepass", version = "4.3.6-linera.3" }
wasmparser = "0.101.1"
wasmtime = "24.0.0"
# TODO(#2430): use the latest release of Wasmtime that includes the commit referenced below
wasmtime = { git = "https://github.com/bytecodealliance/wasmtime", rev = "58f82587462543e912b4edcbb247842711ba6415" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix we need hasn't been released yet. I added a TODO to update this once a release is available (they tend to release often, so hopefully soon).

wasmtimer = "0.2.0"
webassembly-test = "0.1.0"
web-sys = "0.3.69"
Expand Down
Loading
Loading