Make service runtime short-lived by default #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
changed the title
jvff
approved these changes
Sep 5, 2024
ma2bd
force-pushed
the
service_runtime
branch
from
edd931e
to
f6fa238
Compare
ma2bd
force-pushed
the
service_runtime
branch
from
0e04672
to
fdd5435
Compare
ma2bd
commented
Sep 5, 2024
ma2bd
commented
Sep 5, 2024
| @@ -45,6 +45,14 @@ pub struct ExecutionStateView<C> { | |||
| pub users: HashedReentrantCollectionView<C, UserApplicationId, KeyValueStoreView<C>>, | |||
| } | |||
|
|
|||
| /// How to interact with a long-lived service runtime. | |||
| pub struct ServiceRuntimeEndpoint { | |||
There was a problem hiding this comment.
Should it be ApplicationServiceEndpoint ?
There was a problem hiding this comment.
Ok so there are several names to change so this will have to wait another PR
Twey
reviewed
Sep 5, 2024
Comment on lines
+106
to
+108
| let (committee, worker) = init_worker( | ||
| storage, /* is_client */ false, /* has_long_lived_services */ false, | ||
| ); |
jvff
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Make long lived services optional (and not the default) * fix README of LLM * fix help * fix worker tests * address comments * fix execution tests * update CLI.md
ma2bd
added a commit
that referenced
this pull request
Sep 6, 2024
* Make long lived services optional (and not the default) * fix README of LLM * fix help * fix worker tests * address comments * fix execution tests * update CLI.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The long-lived services are somehow experimental and are mostly used for the LLM demo.
Stability issues were solved but we should probably not activate long-lived services by default anyway.
Proposal
Test Plan
Release Plan