Make all_messages_delivered_up_to take tracked_chains into account.

[afck]

Motivation

#2035 introduced a list of "tracked chains": In the local node, messages to non-tracked chains are not delivered and stay in the outbox.

However, all_messages_delivered_up_to doesn't take that into account yet, so if a chain is sending a message to a non-tracked chain, it would never return true, and if wait_for_outgoing_messages is true, handle_certificate could wait forever.

Proposal

Return true from all_messages_delivered_up_to if all messages to tracked chains have been delivered, ignoring remaining outbox entries for untracked chains.

TBD: This makes wait_for_outgoing_messages async and potentially much slower. We could instead add tracked_outbox_counters that count only messages to tracked chains. This would need to be updated when the set of tracked chains changes, however.

Test Plan

TBD: I should add a regression test for this.

Release Plan

• These changes should be backported to the latest devnet branch, then
  • be released in a new SDK,
• These changes should be backported to the latest testnet branch, then
  • be released in a new SDK,

Links

• Tracked chains PR: Limit network actions to tracked chains #2035
• reviewer checklist

[ma2bd]

Could we instead increment the counters right away for the messages to untracked chains?

[ma2bd]

or just what you said: tracked_outbox_counters
perhaps we can also have: untracked_outbox_counters to support future changes in the tracked chains

[afck]

Actually, maybe the outbox_counters just need to refer only to the tracked chains. When those change, the counters have to be recomputed from the outboxes themselves anyway.

[afck]

…but then I wonder if we should move it from the (persisted) chain state view to the worker state?

[ma2bd]

This works for me!

[ma2bd]

(now that chain states are long lived)