Make finalize-committee a separate command. #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
approved these changes
Oct 8, 2024
afck
force-pushed
the
finalize-committee
branch
from
f01e2b5
to
0557364
Compare
afck
added a commit
to afck/linera-protocol
that referenced
this pull request
Oct 8, 2024
ma2bd
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't want to deprecate old committees by default, especially on the public devnets and testnets.
Proposal
Make
finalize-committeea separate command.Test Plan
We use it in the reconfiguration test now, and check that there is only one committee left at the end.
Release Plan
testnetbranch, thenLinks