Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code to convert First/rest structure to Collection objects #575

Merged
merged 7 commits into from
Sep 28, 2022
Merged

Conversation

timbl
Copy link
Member

@timbl timbl commented Sep 25, 2022

This is needed because CSS tends to serialize lists as first/rest form rather than in Turtle ( parens collections ) form. This PR does not (yet) add that processing after the parsing of a turtle file

src/collection.ts Outdated Show resolved Hide resolved
src/lists.ts Outdated Show resolved Hide resolved
timbl and others added 2 commits September 27, 2022 12:51
Thanks @TallTed

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Copy link
Contributor

@bourgeoa bourgeoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There an issue in npm run prepublishOnly
https://stackoverflow.com/questions/55680391/typescript-error-ts2403-subsequent-variable-declarations-must-have-the-same-typ

npm uninstall @types/mocha

resolves the issue

Copy link
Contributor

@bourgeoa bourgeoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing @types/mocha --> no types issues

else LGTM

@timbl timbl merged commit 506bc19 into main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants