- Fix an issue where the duration is less than 1 sec, which will divide by zero exception #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ma7moudHatem
commented
Mar 16, 2021
•
Ma7moudHatem
commented
- Fix an issue where the duration is less than 1 sec, which will cause a divide by zero exception.
- Convert the Micros to seconds as a float to count the fractions of a second
…e divide by zero exception - Release unused anymore MediaMetadataRetriever instance - In PassthroughSoftwareRenderer, make FRAME_WAIT_TIMEOUT equals to 0, because on some device the current value cause an almost infinite processing time
litr/src/main/java/com/linkedin/android/litr/utils/TranscoderUtils.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/utils/TimeUtils.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/utils/TimeUtils.java
Outdated
Show resolved
Hide resolved
litr/src/main/java/com/linkedin/android/litr/utils/TranscoderUtils.java
Outdated
Show resolved
Hide resolved
Ma7moudHatem
deleted the
fix-estimate_video_track_bitrate_issue_and_others
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.