ensure FileReader close()es during avro parse

linkedin · Apr 29, 2024 · 2631cd0 · 2631cd0
1 parent 9321e76
commit 2631cd0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/parser/src/main/java/com/linkedin/avroutil1/parser/avsc/AvscParser.java b/parser/src/main/java/com/linkedin/avroutil1/parser/avsc/AvscParser.java
@@ -144,13 +144,12 @@ public AvscParseResult parse(Path avscFile) {
 
     public AvscParseResult parse(File avscFile) {
         AvscFileParseContext context = new AvscFileParseContext(avscFile, this);
-        Reader reader;
-        try {
-            reader = new FileReader(avscFile);
+        ;
+        try (Reader reader = new FileReader(avscFile)) {
+            return parse(context, reader);
         } catch (FileNotFoundException e) {
             throw new IllegalStateException("input file " + avscFile.getAbsolutePath() + " not found", e);
         }
-        return parse(context, reader);
     }
 
     private AvscParseResult parse(AvscFileParseContext context, Reader reader) {