Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve root cause of SpecificCompiler instantiation failure, also avro 1.10.2 #201

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

radai-rosenblatt
Copy link
Contributor

resolves #197

@codecov-commenter
Copy link

Codecov Report

Merging #201 (81b88b4) into master (e2de48d) will increase coverage by 0.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
+ Coverage     25.59%   25.68%   +0.09%     
- Complexity     1206     1207       +1     
============================================
  Files           189      190       +1     
  Lines         14984    15008      +24     
  Branches       2311     2312       +1     
============================================
+ Hits           3835     3855      +20     
- Misses        10699    10701       +2     
- Partials        450      452       +2     
Impacted Files Coverage Δ
...nkedin/avroutil1/compatibility/ExceptionUtils.java 33.33% <33.33%> (ø)
...vroutil1/compatibility/avro110/Avro110Adapter.java 58.08% <75.00%> (+0.94%) ⬆️
.../avroutil1/compatibility/avro15/Avro15Adapter.java 57.39% <75.00%> (+1.14%) ⬆️
.../avroutil1/compatibility/avro16/Avro16Adapter.java 56.48% <75.00%> (+1.01%) ⬆️
.../avroutil1/compatibility/avro17/Avro17Adapter.java 61.87% <75.00%> (+0.72%) ⬆️
.../avroutil1/compatibility/avro18/Avro18Adapter.java 58.08% <75.00%> (+0.94%) ⬆️
.../avroutil1/compatibility/avro19/Avro19Adapter.java 58.39% <75.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2de48d...81b88b4. Read the comment docs.

Copy link
Collaborator

@FelixGV FelixGV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radai-rosenblatt radai-rosenblatt merged commit c1ab693 into linkedin:master Sep 25, 2021
@radai-rosenblatt radai-rosenblatt deleted the issue-197 branch September 25, 2021 00:05
@srramach srramach added the helper related to the compatibility helper label Oct 2, 2021
flowenol pushed a commit to RTBHOUSE/avro-util that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helper related to the compatibility helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print _root_ cause exception when avro compiler not found on classpath
4 participants