Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metric Registration Issue for Throughput Violations Reporting #942

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Fix Metric Registration Issue for Throughput Violations Reporting #942

merged 3 commits into from
Jun 1, 2023

Conversation

shrinandthakkar
Copy link
Collaborator

Changes in this PR:

  • Registering the Event Producer's metrics to be reported for throughput-violating topics at initialization.
  • Fixed the Gauge metric's registration as well via regex-based prefix, which reports the number of throughput-violating topics.

atoomula
atoomula approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@atoomula atoomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shrinandthakkar shrinandthakkar merged commit f5d99f6 into linkedin:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaheshw vmaheshw vmaheshw approved these changes

@atoomula atoomula atoomula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrinandthakkar @atoomula @vmaheshw