[Coral-Trino] Remove characters sets from TrinoSqlDialect #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Previously,
charSetName
was dropped from VARCHAR/CHAR fields when a Coral RelNode is being converted to a Trino SqlNode. This happened by overridingsupportsCharSet
to be false inTrinoSqlDialect
. As art of mergingTrinoSqlDialect
->CoralSqlDialect
, we wantTrinoSqlDialect
to matchCoralSqlDialect
meaning the override needed to be undone.Now,
charSetName
is instead dropped from VARCHAR/CHAR fields dropped as part of SqlNode rewriting inTrinoSqlRewriter
by adding a datatype replacement rule.How was this patch tested?
CAST
calls that are nested