[Coral-Trino] Avoid accidental translation of Trino from_unixtime SQL call - SqlFunction implementation
#467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
findinpath/from_unixtime_operator
branch
2 times, most recently
from
061055f
to
07ac623
Compare
findinpath
changed the title
from_unixtime SQL callfrom_unixtime SQL call
|
I have made a small fix in |
|
Fixed the remaining test case. |
…QL call Co-authored-by: Walaa Eldin Moustafa <wmoustafa@linkedin.com>
findinpath
force-pushed
the
findinpath/from_unixtime_operator
branch
from
cbe144d
to
e5d6ae6
Compare
findinpath
changed the title
from_unixtime SQL callfrom_unixtime SQL call
This was referenced Oct 22, 2023
findinpath
changed the title
from_unixtime SQL callfrom_unixtime SQL call - SqlFunction implementation
wmoustafa
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Avoid the accidental translation of the Trino from_unixtime introduced through #426
Context #459 (comment)
Fixes #459
Spin-off from #464 to showcase the solution based on
TimestampFromUnixtimeSqlOperatorimplementation.How was this patch tested?
Integration tests