add support for recursively set default value in test mode #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealChrisL
reviewed
Nov 1, 2024
| /** | ||
| * For unit tests | ||
| */ | ||
| valueWithDefault: string = "" |
There was a problem hiding this comment.
to add other/complex default data structure in test model? such as nested and map {}?
| @@ -77,6 +79,27 @@ public static String toJsonString(@Nonnull RecordTemplate recordTemplate) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Serializes a {@link RecordTemplate} to JSON string. | |||
| *Also take test mode as input to control the default value fill in strategy | |||
RealChrisL
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for recursively set default value in test mode
Testing Done
Add unit test
Also this only change the behavior for test mode, will not affect the prod behavior at all
snapshot the version and deploy to local to make sure it works, but it won't change the data for things that already set to empty.
Checklist