Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mockito to 2.28.2 #153

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Update mockito to 2.28.2 #153

merged 1 commit into from
Dec 5, 2019

Conversation

chao2zhang
Copy link
Contributor

We have encountered exceptions when initializing the mocker maker
plugin when using mockito-inline in tandem with
dexmaker-mockito-inline at 2.25.0. This pull request bumped to the
latest mockito2 version to pick up the update of bytebuddy.

Exception
https://gist.github.com/chao2zhang/ee1160612491376daf63fd5a60e1757d

Copy link
Contributor

@drewhannay drewhannay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note to the changelog as well, saying we updated Mockito to 2.28.2?

@chao2zhang
Copy link
Contributor Author

Can you add a note to the changelog as well, saying we updated Mockito to 2.28.2?

Of course, I updated the diff here https://github.com/linkedin/dexmaker/pull/153/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1e

CHANGELOG.md Outdated
@@ -2,6 +2,7 @@

## Version 2.25.2-SNAPSHOT
- Support generating locals that reference generated class types - [#151](https://github.com/linkedin/dexmaker/pull/151)
- Update Mockito to 2.25.0 - [#153](https://github.com/linkedin/dexmaker/pull/153)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the right version number ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

We have encountered exceptions when initializing the mocker maker
plugin when using mockito-inline in tandem with
dexmaker-mockito-inline at 2.25.0. This pull request bumped to the
latest mockito2 version to pick up the update of bytebuddy.

Exception
https://gist.github.com/chao2zhang/ee1160612491376daf63fd5a60e1757d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants