-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common][server] Bug fixes and clean of ACL handlers for GRPC #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, just one question/concern.
internal/venice-common/src/main/java/com/linkedin/venice/acl/handler/StoreAclHandler.java
Outdated
Show resolved
Hide resolved
5ba0b11
to
f3de717
Compare
@xunyin8 I think i narrowed down the issue with mockito-inline upgrade which doesn't play well with the bytebuddy we pull in transitively. For now, reverting the mockito dependency upgrade and removed the test that requires mocking static utility. Will have a separate PR to fix the mocking issue (for mocking static and final classes) |
This reverts commit 53810c2.
f3de717
to
b48b189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge once the tests are passing.
Summary
onMessage
twice in GRPC call intercept to prevent exceptionsGrpcSSLUtils
toGrpcUtils
to accommodate general utility methodsHow was this PR tested?
Does this PR introduce any user-facing changes?