Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common][server] Bug fixes and clean of ACL handlers for GRPC #982

Merged
merged 7 commits into from
May 22, 2024

Conversation

mynameborat
Copy link
Contributor

@mynameborat mynameborat commented May 13, 2024

Summary

  • Consolidate boiler plate code in ACL handlers for access validations
  • Fix code path that throws exception in GRPC and close the calls with the appropriate error messages
  • Fix the flow that invokes onMessage twice in GRPC call intercept to prevent exceptions
  • Rename GrpcSSLUtils to GrpcUtils to accommodate general utility methods
  • Add reflection service to GRPC server to interact with Grpcurl
  • Reuse the header for skipping ACLs from router since the store ACL handling is performed at the router for non FC clients
  • [code readability] Move public methods together followed by overridable and protected methods followed by package private and private methods

How was this PR tested?

  • Unit tests
  • Integration tests
  • Deployment to certification cluster to validate the flow using sample venice application

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Contributor

@xunyin8 xunyin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, just one question/concern.

@mynameborat mynameborat force-pushed the grpc-acl-updates branch 2 times, most recently from 5ba0b11 to f3de717 Compare May 21, 2024 22:41
@mynameborat
Copy link
Contributor Author

@xunyin8 I think i narrowed down the issue with mockito-inline upgrade which doesn't play well with the bytebuddy we pull in transitively. For now, reverting the mockito dependency upgrade and removed the test that requires mocking static utility.

Will have a separate PR to fix the mocking issue (for mocking static and final classes)

Copy link
Contributor

@xunyin8 xunyin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once the tests are passing.

@mynameborat mynameborat enabled auto-merge (squash) May 21, 2024 23:50
@mynameborat mynameborat merged commit 2720a83 into linkedin:main May 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants