Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] CI build fix #997

Merged
merged 1 commit into from
May 21, 2024
Merged

[controller] CI build fix #997

merged 1 commit into from
May 21, 2024

Conversation

majisourav99
Copy link
Contributor

CI build fix

[controller] CI build fix

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

FelixGV
FelixGV approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@FelixGV FelixGV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sourav! Looks like one more rebase sneaked in by the time I merged my PR 😅 ...

@majisourav99
Copy link
Contributor Author

Thanks Sourav! Looks like one more rebase sneaked in by the time I merged my PR 😅 ...

Wondering how to catch these issue before merge. Rebasing did not show conflict as the lines were not changed. So we must always rebase + compile to make sure its safe.

@adamxchen adamxchen enabled auto-merge (squash) May 21, 2024 22:48
@adamxchen adamxchen merged commit 0a64bf4 into linkedin:main May 21, 2024
32 checks passed
@majisourav99 majisourav99 deleted the ciFix branch May 22, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantmane sushantmane sushantmane approved these changes

@FelixGV FelixGV FelixGV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majisourav99 @FelixGV @sushantmane @adamxchen