Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Disallow lock and instant types from std #1458

Merged
merged 6 commits into from
Feb 2, 2022
Merged

clippy: Disallow lock and instant types from std #1458

merged 6 commits into from
Feb 2, 2022

Commits on Feb 1, 2022

  1. clippy: Disallow lock and instant types from std 

    We use `parking_lot` locks throughout our code. This change disallows the
introduction of std::sync's locks.

This change also enforces the use of `tokio::time::Instant`, which
allows for a mockable time source in tests.

Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    7e407f6 View commit details
    Browse the repository at this point in the history

  2. Update .clippy.toml

    @olix0r
    olix0r authored Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9fcd0d8 View commit details
    Browse the repository at this point in the history

  3. fmt 

    Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    9ef47d6 View commit details
    Browse the repository at this point in the history

  4. Revert switch to tokio::time::Duration; use disallowed-types lint

    @olix0r
    olix0r committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    31f919e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Instrument disallowed type bans

    @olix0r
    olix0r committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    19aa378 View commit details
    Browse the repository at this point in the history

  2. fmt

    @olix0r
    olix0r committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    a2a0a75 View commit details
    Browse the repository at this point in the history