Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the connection's HTTP version in transport header #1533

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Use the connection's HTTP version in transport header #1533

merged 4 commits into from
Mar 9, 2022

Commits on Mar 9, 2022

  1. Use the connection's HTTP version in transport header 

    Currently, when the outbound proxy communicates with a meshed endpoint
that uses opaque transport (i.e. multi-cluster gateways), it *always*
sets the gateway header's session protocol to HTTP/2, since the meshed
endpoint supports HTTP/2 protocol upgrading. But the HTTP client may
choose not to use HTTP/2 if the request includes the `Upgrade` header,
as it does for WebSocket connections. In these cases, the transport
header should indicate that the connection is HTTP/1.

This change modifies the HTTP client to pass the used protocol version
when building a connection. This value is then used to set the session
protocol header when it is required..

Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    3450768 View commit details
    Browse the repository at this point in the history

  2. Fix tests 

    Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    87361ab View commit details
    Browse the repository at this point in the history

  3. Add an HTTP upgrade orig-proto test 

    Test that orig-proto upgrading properly handles HTTP upgrade requests.

Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    7eb1399 View commit details
    Browse the repository at this point in the history

  4. inline 

    Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    5adea95 View commit details
    Browse the repository at this point in the history