Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outbound: Preserve opaqueness on unknown endpoints #1617

Merged
merged 2 commits into from
Apr 19, 2022
Merged

outbound: Preserve opaqueness on unknown endpoints #1617

merged 2 commits into from
Apr 19, 2022

Commits on Apr 19, 2022

  1. outbound: Preserve opaqueness on unknown endpoints 

    The outbound stack only honors opaqueness when the profile response
clearly indicates that the target is a known endpoint or logical
service. This ignores the case when the target is unknown but the target
port is in the default opaque ports list, in which case the profile
response has no metadata except for the opaqueness setting.

This change handles this case explicitly and adds a test for the
`switch_logical` stack to ensure that these profile responses are
honored.

Fixes linkerd/linkerd2#8273

Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    24a04d1 View commit details
    Browse the repository at this point in the history

  2. fixup comments 

    Signed-off-by: Oliver Gould <ver@buoyant.io>
    @olix0r
    olix0r committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    e76842d View commit details
    Browse the repository at this point in the history