refactor(proxy/http): create linkerd-http-insert crate
#3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Nov 21, 2024
this pulls out the `insert` module from `linkerd-proxy-http`. a reëxport is added so that this does not affect the public api of the http crate. NB: based on #3379. Signed-off-by: katelyn martin <kate@buoyant.io>
this commit adds documentation to `linkerd-http-insert`. Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/yoink-http-insert
branch
from
520d264 to
169c000
Compare
cratelyn
added a commit
that referenced
this pull request
Nov 26, 2024
* refactor(proxy/http): move types to `linkerd-http-classify` (#3382) in this case we already had a crate defining the classify traits, but the http body and other assorted middleware were defined in `linkerd-proxy-http`. this commit moves those types to the `linkerd-http-classify` crate, which astute readers may notice, is a concrete step towards simplifying the `linkerd-proxy-http` crate's upgrade process. one small detail worth calling out: we implement `http_body::Body` directly, to avoid taking on a `hyper` dependency. otherwise, nothing has changed in the `channel`, `gate`, and `insert` middleware. Signed-off-by: katelyn martin <kate@buoyant.io> * refactor(proxy/http): create `linkerd-http-retain` crate (#3382) this moves the `Retain` middleware from `linkerd-proxy-http` into a new `linkerd-http-retain` crate. as previously, reëxports are added to make this a backwards compatible change. this moves another http body middleware out of the proxy's core http crate. great news. Signed-off-by: katelyn martin <kate@buoyant.io> * refactor(proxy/http): create `linkerd-http-stream-timeouts` crate (#3382) this commit outlines the stream timeout middleware, pulling it out of `linkerd-proxy-http` and into a standalone crate. again, reëxports are added to make this a backwards compatible change. Signed-off-by: katelyn martin <kate@buoyant.io> * refactor(proxy/http): create `linkerd-http-override-authority` crate (#3382) NB: based on #3379 and #3380. this pull the `override_authority` submodule out of `linkerd-http-proxy` and into a standalone crate. Signed-off-by: katelyn martin <kate@buoyant.io> * refactor(proxy/http): move `is_bad_request()` into `upgrade` (#3382) this is only used in once place, so as a brief chore before we move the upgrade submodule out into its own crate, we pull `is_bad_request()` next to its call site. Signed-off-by: katelyn martin <kate@buoyant.io> * refactor(proxy/http): create `linkerd-http-upgrade` crate (#3382) this moves the inter-related `upgrade` and `glue` submodules out of the `linkerd-proxy-http` library and into a new standalone crate. Signed-off-by: katelyn martin <kate@buoyant.io> --------- Signed-off-by: katelyn martin <kate@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pulls out the
insertmodule fromlinkerd-proxy-http.a reëxport is added so that this does not affect the public api of the
http crate.
NB: based on #3379.