Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gitignore): ignore .cargo directory #3451

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cratelyn
Copy link
Collaborator

this commit supercedes #3443.

we use the kubert crate to export a collection of metrics measuring the behavior of our asynchronous tokio runtime.

in order for this crate to compile, one must set a compile-time flag. this can be done either by setting the RUSTFLAGS environment variable, or via a toml file in .cargo/config.toml.

helpful links:

this commit adds .cargo to the repository's gitignore, so that people may freely modify cargo configuration as needed when building the project from source.

@cratelyn cratelyn marked this pull request as ready for review December 11, 2024 15:33
@cratelyn cratelyn requested a review from a team as a code owner December 11, 2024 15:33
this commit supercedes #3443.

we use the kubert crate to export a collection of metrics measuring the
behavior of our asynchronous tokio runtime.

in order for this crate to compile, one must set a compile-time flag.
this can be done either by setting the RUSTFLAGS environment variable,
or via a toml file in .cargo/config.toml.

helpful links:

- <https://github.com/olix0r/kubert?tab=readme-ov-file#kubert-prometheus-tokio>
- <https://docs.rs/tokio-metrics/latest/tokio_metrics/>
- <https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags>

this commit adds `.cargo` to the repository's gitignore, so that people
may freely modify cargo configuration as needed when building the
project from source.

Signed-off-by: katelyn martin <kate@buoyant.io>
@cratelyn cratelyn force-pushed the kate/add-cargo-config-directory-to-gitignore branch from f0ca00a to 33f3107 Compare December 11, 2024 15:50
@cratelyn cratelyn merged commit f31cf1f into main Dec 11, 2024
15 checks passed
@cratelyn cratelyn deleted the kate/add-cargo-config-directory-to-gitignore branch December 11, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants