chore(deny.toml): remove stale idna directive
#3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if one runs `cargo deny check` on the current state of main, or checks
deny logs in ci, one observes this waning:
```sh
$ cargo deny check
warning[unnecessary-skip]: skip 'idna' applied to a crate with only one version
┌─ /path/to/linkerd/linkerd2-proxy/deny.toml:63:15
│
63 │ { name = "idna" },
│ ━━━━ unnecessary skip configuration
advisories ok, bans ok, licenses ok, sources ok
```
today, our dependency graph only contains one version of `idna`, which
has since release a 1.0 version:
```sh
$ cargo tree -i -p idna
idna v1.0.3
├── hickory-proto v0.24.2
└── url v2.5.4
```
this commit updates the `deny.toml` file, removing this directive to
permit duplicate versions, now that this is no longer the case.
Signed-off-by: katelyn martin <kate@buoyant.io>
olix0r
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if one runs
cargo deny checkon the current state of main, or checks deny logs in ci, one observes this waning:today, our dependency graph only contains one version of
idna, which has since release a 1.0 version:this commit updates the
deny.tomlfile, removing this directive to permit duplicate versions, now that this is no longer the case.