outbound: stack tests for idling out services #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
changed the title
hawkw
commented
Dec 11, 2020
linkerd/app/outbound/src/server.rs
Outdated
| } | ||
|
|
||
| pub fn stack_with_tcp_balancer<P, C, T, H, S, I>( | ||
| pub fn cache_accept<N, S, I>( |
There was a problem hiding this comment.
Open to bikeshed the name of this function (and accept_with_tcp_balancer), I had to split these out to sneak in the tracking layer at the right point in the stack.
There was a problem hiding this comment.
How about just cache for this? There's nothing to disambiguate this with, given that it's in the server module. And for accept_with_tcp_balancer, how about just stack?
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
...not the stack that's cloned into hyper's `serve_connection`. This required slicing up the stack construction a bit to sneak the track layer in at the correct place, sorry in advance for merge conflicts @olix0r :P Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/test-stacks-idle-out
branch
from
170d41d
to
33e5753
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
|
Closing this as we merged it directly into #768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds new stack tests in the outbound crate testing behavior
around dropping idle services. I've added a new test utility for
wrapping a
NewServiceto track the number of currently aliveServiceinstances created by that
NewService, using anArc. The tests canthen wrap the HTTP router stack with this wrapper, and make assertions
about how many services are alive.
I had to do a bit of stack surgery to fit the tracking layer in the right place.
Sorry in advance for any merge conflicts.
This branch adds two tests. One asserts that services are dropped after
the idle timeout when they are inactive, and another asserts that
services which are currently streaming response bodies are not idled
out.
The second of these tests fails on
main, which is expected. We expectPR #768 to fix this.
Depends on #765.