Assign fixed widths to the metrics in the Top columns

linkerd · Sep 12, 2018 · 40f9614 · 40f9614
1 parent 5325c85
commit 40f9614
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/web/app/js/components/TopEventTable.jsx b/web/app/js/components/TopEventTable.jsx
@@ -5,6 +5,7 @@ import { withContext } from './util/AppContext.jsx';
 import { directionColumn, srcDstColumn } from './util/TapUtils.jsx';
 import { formatLatencySec, numericSort } from './util/Utils.js';
 
+const topMetricColWidth = "80px";
 const topColumns = (resourceType, ResourceLink) => [
   {
     title: " ",
@@ -26,24 +27,28 @@ const topColumns = (resourceType, ResourceLink) => [
   {
     title: "Count",
     dataIndex: "count",
+    width: topMetricColWidth,
     defaultSortOrder: "descend",
     sorter: (a, b) => numericSort(a.count, b.count),
   },
   {
     title: "Best",
     dataIndex: "best",
+    width: topMetricColWidth,
     sorter: (a, b) => numericSort(a.best, b.best),
     render: formatLatencySec
   },
   {
     title: "Worst",
     dataIndex: "worst",
+    width: topMetricColWidth,
     sorter: (a, b) => numericSort(a.worst, b.worst),
     render: formatLatencySec
   },
   {
     title: "Last",
     dataIndex: "last",
+    width: topMetricColWidth,
     sorter: (a, b) => numericSort(a.last, b.last),
     render: formatLatencySec
   },

diff --git a/web/app/js/components/TopModule.jsx b/web/app/js/components/TopModule.jsx
@@ -25,7 +25,7 @@ class TopModule extends React.Component {
     // max rows to keep in index. there are two indexes we keep:
     // - un-ended tap results, pre-aggregation into the top counts
     // - aggregated top rows
-    maxRowsToStore: 40,
+    maxRowsToStore: 50,
     updateNeighbors: _.noop
   }