lint: Enable unconvert (#2368)

unconvert removes unnecessary type conversions:
https://github.com/mdempsky/unconvert

Part of #217

Signed-off-by: Andrew Seigner <siggy@buoyant.io>

.golangci.yml

@@ -1,3 +1,10 @@
+# This file specifies which linters golangci-lint should run.
+#
+# For descriptions of all available linters, run:
+# ./.golangci-lint-1.15.0 linters
+# or browse to:
+# https://github.com/golangci/golangci-lint#supported-linters
+
 run:
   deadline: 5m
 issues:
@@ -17,6 +24,7 @@ linters:
   - nakedret
   - scopelint
   - typecheck
+  - unconvert
   - unused
   - varcheck
   # TODO: enable more linters!
@@ -30,7 +38,6 @@ linters:
   # - maligned
   # - prealloc
   # - stylecheck
-  # - unconvert
   # - unparam
   disable:
   - errcheck

pkg/profiles/profiles.go

@@ -336,7 +336,7 @@ func ToRequestMatch(reqMatch *sp.RequestMatch) (*pb.RequestMatch, error) {
 // - recursive fields
 func Validate(data []byte) error {
 	var serviceProfile sp.ServiceProfile
-	err := yaml.UnmarshalStrict([]byte(data), &serviceProfile)
+	err := yaml.UnmarshalStrict(data, &serviceProfile)
 	if err != nil {
 		return fmt.Errorf("failed to validate ServiceProfile: %s", err)
 	}

pkg/profiles/tap_test.go

@@ -102,7 +102,7 @@ func TestTapToServiceProfile(t *testing.T) {
 		},
 	}
 
-	actualServiceProfile, err := tapToServiceProfile(mockAPIClient, tapReq, namespace, name, tapDuration, int(routeLimit))
+	actualServiceProfile, err := tapToServiceProfile(mockAPIClient, tapReq, namespace, name, tapDuration, routeLimit)
 	if err != nil {
 		t.Fatalf("Failed to create ServiceProfile: %v", err)
 	}