Skip to content

Commit

Permalink
Increase integration test timeouts (#2360)
Browse files Browse the repository at this point in the history
The integration tests occasionally timeout in ci when talking to
Kubernetes and Linkerd:
https://travis-ci.org/linkerd/linkerd2/jobs/497300669#L972
https://travis-ci.org/linkerd/linkerd2/jobs/497329339#L7284

Increase `linkerd check --wait` from `0` to `30s`.
Increase `HTTPGetURL` timeout from 30s to 1 minute.

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
  • Loading branch information
siggy authored Feb 23, 2019
1 parent 7fa7e96 commit e300309
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ jobs:
go_import_path: github.com/linkerd/linkerd2
cache:
directories:
- $HOME/.cache/go-build
- target
- vendor
- "$HOME/.cache"
install:
- ./bin/dep ensure -vendor-only -v
- ./bin/dep status -v
Expand Down
4 changes: 2 additions & 2 deletions test/install_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func TestVersionPostInstall(t *testing.T) {
}

func TestCheckPostInstall(t *testing.T) {
cmd := []string{"check", "--expected-version", TestHelper.GetVersion(), "--wait=0"}
cmd := []string{"check", "--expected-version", TestHelper.GetVersion(), "--wait=1m"}
golden := "check.golden"
if TestHelper.SingleNamespace() {
cmd = append(cmd, "--single-namespace")
Expand Down Expand Up @@ -229,7 +229,7 @@ func TestInject(t *testing.T) {

func TestCheckProxy(t *testing.T) {
prefixedNs := TestHelper.GetTestNamespace("smoke-test")
cmd := []string{"check", "--proxy", "--expected-version", TestHelper.GetVersion(), "--namespace", prefixedNs, "--wait=0"}
cmd := []string{"check", "--proxy", "--expected-version", TestHelper.GetVersion(), "--namespace", prefixedNs, "--wait=1m"}
golden := "check.proxy.golden"
if TestHelper.SingleNamespace() {
cmd = append(cmd, "--single-namespace")
Expand Down
2 changes: 1 addition & 1 deletion testutil/test_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (h *TestHelper) RetryFor(timeout time.Duration, fn func() error) error {
// giving pods time to start.
func (h *TestHelper) HTTPGetURL(url string) (string, error) {
var body string
err := h.RetryFor(30*time.Second, func() error {
err := h.RetryFor(time.Minute, func() error {
resp, err := h.httpClient.Get(url)
if err != nil {
return err
Expand Down

0 comments on commit e300309

Please sign in to comment.