Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar namespace filter forgets where it is #1543

Closed
grampelberg opened this issue Aug 29, 2018 · 0 comments · Fixed by #1613
Closed

Sidebar namespace filter forgets where it is #1543

grampelberg opened this issue Aug 29, 2018 · 0 comments · Fixed by #1613
Assignees
@dadjeibaah
Labels
area/web bug review reviewable size/small

Comments

@grampelberg
Copy link
Contributor

The sidebar really likes to have All Namespaces selected. I had emojivoto selected, hid the sidebar and the filtering stuck but the dropdown reverted.

screenshot 2018-08-29 09 27 53
@dadjeibaah dadjeibaah mentioned this issue Sep 7, 2018
Merged
@dadjeibaah dadjeibaah self-assigned this Sep 7, 2018
dadjeibaah pushed a commit that referenced this issue Sep 12, 2018
Add breadcrumb navigation at the top of linkerd dashboard (#1613)
b1181e5 
This PR adds a breadcrumb style navigation to the Linkerd dashboard. Each "crumb" links to its corresponding page in the UI.

This PR also includes a small UI fix in the sidebar. The select box always seems to revert to the All Namespaces option whenever there is a state change on the React side. The fix ensures that the select box always displays the namespace filter if it is available and revert to All Namespaces when no namespace is selected.

fixes #1464
fixes #1543
fixes #1627

Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dadjeibaah dadjeibaah

Labels
area/web bug review reviewable size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add breadcrumb navigation at the top of linkerd dashboard linkerd/linkerd2
3 participants
@grampelberg @rmars @dadjeibaah