refactor(multicluster): Replace use of unstructured API with typed bindings for Link CR #13420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
alpeb
reviewed
Dec 6, 2024
| cleanupWorkers() | ||
| // Use a small buffered channel for Link updates to avoid dropping | ||
| // updates if there is an update burst. | ||
| results := make(chan *v1alpha2.Link, 100) |
There was a problem hiding this comment.
Would be cool as a followup to get a metric on the size of this queue and/or the number of dropped updates
| @@ -58,7 +58,7 @@ rules: | |||
| verbs: ["list", "get", "watch"] | |||
| - apiGroups: ["multicluster.linkerd.io"] | |||
| resources: ["links/status"] | |||
| verbs: ["update"] | |||
| verbs: ["update", "patch"] | |||
There was a problem hiding this comment.
Do you know if we still require update here?
There was a problem hiding this comment.
I don't believe so, but it might be safer to keep it to give us more flexibility in terms of the exact API calls that are used to update the status.
adleong
changed the title
alpeb
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linkerd-multicluster extension uses client-go's
unstructuredAPI to access Link custom resources. This API allowed us to develop quickly without the work of generating typed bindings. However, using the unstrucutred API is error prone since fields must be accessed by their string name. It is also inconsistent with the rest of the project which uses typed bindings.We replace the use of the unstructured API for Link resources with generated typed bindings. The client-go APIs are slightly different and client-go does not provide a way to update subresources for typed bindings. Therefore, when updating a Link's status subresource, we use a patch instead of an update.