chore(ci): simplify protoc scripts #13459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
changed the title
The bin/protoc script is ancient and not useful, especially in light of tools provided by dev containers. Furthermore, it includes a reference to an old gross sourcefource downlaod page for unzip. Furthermore, the protoc-go.sh script does seperate version pinning of build dependencies. To simplify all of this, this change removes the bin/protoc and bin/protoc-diff scripts. The "proto" CI workflow is updated to use the protoc-go.sh script directly.
olix0r
changed the title
sfleen
approved these changes
Dec 11, 2024
cratelyn
approved these changes
Dec 11, 2024
adleong
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bin/protoc script is ancient and not useful, especially in light of tools
provided by dev containers. Furthermore, it includes a reference to an old gross
sourcefource downlaod page for unzip.
Furthermore, the protoc-go.sh script does seperate version pinning of build
dependencies.
To simplify all of this, this change removes the bin/protoc and bin/protoc-diff
scripts. The "proto" CI workflow is updated to use the protoc-go.sh script
directly.