Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add validation for proxyInit.closeWaitTimeoutSecs #13481

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Dec 13, 2024

Fixes #13458

The proxyInit.closeWaitTimeoutSecs config triggers a call sysctl -w net.netfilter.nf_conntrack_tcp_timeout_close_wait=x by linkerd-init, which requires root access. So we add a validation such that when that config is used, proxyInit.runAsRoot should be true.

Fixes #13458

The `proxyInit.closeWaitTimeoutSecs` triggers as call `sysctl -w net.netfilter.nf_conntrack_tcp_timeout_close_wait=x` by linkerd-init, which requires root access. So we add a validation such that when that config is used, `proxyInit.runAsRoot` should be true.
@alpeb alpeb requested a review from a team as a code owner December 13, 2024 14:59
charts/partials/templates/_proxy-init.tpl Outdated Show resolved Hide resolved
Co-authored-by: Oliver Gould <ver@buoyant.io>
@alpeb alpeb merged commit f7b3553 into main Dec 13, 2024
38 checks passed
@alpeb alpeb deleted the alpeb/closeWaitTimeoutSecs-validation branch December 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting proxyInit.closeWaitTimeoutSecs causes proxy-init to fail
2 participants