Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update from hyper 0.14.28 to 0.14.32 #13492

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

cratelyn
Copy link
Contributor

this contains some small patches that we're interested in, before we address deprecations and upgrade to hyper 1.0.

see #8733 for more information.

cratelyn added a commit that referenced this pull request Dec 18, 2024
NB: this branch is based upon #13492. see #8733 for more information
about migrating to hyper 1.0.

this enables the `backports` and `deprecated` feature flags in the hyper
dependencies in this project, and addresses warnings. see
<https://hyper.rs/guides/1/upgrading/> for more information about these
feature flags.

largely, the control plane is unaffected by this upgrade, besides the
following changes:

* one usage of a deprecated `hyper::body::aggregate` function is
  updated.

* a `hyper::rt::Executor<E>` implementation, which spawns tasks onto the
  tokio runtime, is provided. once we upgrade to hyper 1.0, we can
  replace this with the executor provided in
  [`hyper-util`](https://docs.rs/hyper-util/latest/hyper_util/rt/tokio/struct.TokioExecutor.html#impl-Executor%3CFut%3E-for-TokioExecutor).

* the `hyper::service::Service<hyper::Request<tonic::body::BoxBody>>`
  implementation for `GrpcHttp` now boxes its returned future, on
  account of `SendRequest` returning an anonymous
  `impl Future<Output = ...>`.

* the `policy-test` additionally depends on the `runtime` feature of
  hyper. this is an artifact of an internal config structure shared by
  the legacy connection builder and the backported connection builder
  containing two keep-alive fields that were feature gated prior to 1.0.

Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
this contains some small patches that we're interested in, before we
address deprecations and upgrade to hyper 1.0.

see #8733 for more information.

Signed-off-by: katelyn martin <kate@buoyant.io>
@cratelyn cratelyn force-pushed the kate/upgrade-hyper-0.14.28-to-0.14.32 branch from 9385c66 to f5b4d45 Compare December 18, 2024 02:26
cratelyn added a commit that referenced this pull request Dec 18, 2024
NB: this branch is based upon #13492. see #8733 for more information
about migrating to hyper 1.0.

this enables the `backports` and `deprecated` feature flags in the hyper
dependencies in this project, and addresses warnings. see
<https://hyper.rs/guides/1/upgrading/> for more information about these
feature flags.

largely, the control plane is unaffected by this upgrade, besides the
following changes:

* one usage of a deprecated `hyper::body::aggregate` function is
  updated.

* a `hyper::rt::Executor<E>` implementation, which spawns tasks onto the
  tokio runtime, is provided. once we upgrade to hyper 1.0, we can
  replace this with the executor provided in
  [`hyper-util`](https://docs.rs/hyper-util/latest/hyper_util/rt/tokio/struct.TokioExecutor.html#impl-Executor%3CFut%3E-for-TokioExecutor).

* the `hyper::service::Service<hyper::Request<tonic::body::BoxBody>>`
  implementation for `GrpcHttp` now boxes its returned future, on
  account of `SendRequest` returning an anonymous
  `impl Future<Output = ...>`.

* the `policy-test` additionally depends on the `runtime` feature of
  hyper. this is an artifact of an internal config structure shared by
  the legacy connection builder and the backported connection builder
  containing two keep-alive fields that were feature gated prior to 1.0.

Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn added a commit that referenced this pull request Dec 18, 2024
NB: this branch is based upon #13492. see #8733 for more information
about migrating to hyper 1.0.

this enables the `backports` and `deprecated` feature flags in the hyper
dependencies in this project, and addresses warnings. see
<https://hyper.rs/guides/1/upgrading/> for more information about these
feature flags.

largely, the control plane is unaffected by this upgrade, besides the
following changes:

* one usage of a deprecated `hyper::body::aggregate` function is
  updated.

* a `hyper::rt::Executor<E>` implementation, which spawns tasks onto the
  tokio runtime, is provided. once we upgrade to hyper 1.0, we can
  replace this with the executor provided in
  [`hyper-util`](https://docs.rs/hyper-util/latest/hyper_util/rt/tokio/struct.TokioExecutor.html#impl-Executor%3CFut%3E-for-TokioExecutor).

* the `hyper::service::Service<hyper::Request<tonic::body::BoxBody>>`
  implementation for `GrpcHttp` now boxes its returned future, on
  account of `SendRequest` returning an anonymous
  `impl Future<Output = ...>`.

* the `policy-test` additionally depends on the `runtime` feature of
  hyper. this is an artifact of an internal config structure shared by
  the legacy connection builder and the backported connection builder
  containing two keep-alive fields that were feature gated prior to 1.0.

Signed-off-by: katelyn martin <kate@buoyant.io>
@cratelyn cratelyn marked this pull request as ready for review December 18, 2024 02:35
@cratelyn cratelyn requested a review from a team as a code owner December 18, 2024 02:35
@alpeb alpeb merged commit c77075c into main Dec 19, 2024
27 checks passed
@alpeb alpeb deleted the kate/upgrade-hyper-0.14.28-to-0.14.32 branch December 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants