Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golangci-lint config to use default golint #2284

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix golangci-lint config to use default golint #2284

merged 1 commit into from
Feb 14, 2019

Conversation

siggy
Copy link
Member

@siggy siggy commented Feb 14, 2019

golangci-lint disables some checks for golint, including checks for
well-formed comments on all exported symbols

This change disables the golangci-lint's exclude-use-default setting,
to run golint with default settings.

Also introduce a .golangci.yml file to centralize config.

Signed-off-by: Andrew Seigner siggy@buoyant.io

Fixes #2239 (comment)

Verified comment checks are working:

$ bin/lint
controller/proxy-injector/webhook.go:28:6: exported type Webhook should have comment or be unexported (golint)
type Webhook struct {
     ^

@siggy
Fix golangci-lint config to use default golint
5b83652 
golangci-lint disables some checks for golint, including checks for
well-formed comments on all exported symbols

This change disables the golangci-lint's `exclude-use-default` setting,
to run golint with default settings.

Also introduce a `.golangci.yml` file to centralize config.

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy self-assigned this Feb 14, 2019
@siggy siggy requested a review from klingerf February 14, 2019 04:29
dadjeibaah
dadjeibaah approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@dadjeibaah dadjeibaah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the addition of .golangci.yml 📦

klingerf
klingerf approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@klingerf klingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️ Thanks for the quick fix!

@klingerf klingerf merged commit 044e0a5 into master Feb 14, 2019
@klingerf klingerf deleted the siggy/golint-exclude-use-default branch February 14, 2019 21:55
@siggy siggy mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klingerf klingerf klingerf approved these changes

@dadjeibaah dadjeibaah dadjeibaah approved these changes

Assignees

@siggy siggy

Labels
area/build area/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siggy @klingerf @dadjeibaah