Enable more linters #2362
Merged
Enable more linters #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siggy
force-pushed
the
siggy/varcheck-lint
branch
from
9e646fe
to
dc85b11
Compare
siggy
force-pushed
the
siggy/varcheck-lint
branch
from
dc85b11
to
e797963
Compare
Enables the following linters: - `deadcode` finds unused code. - `depguard` checks if package imports are in a list of acceptable packages. - `misspell` finds commonly misspelled English words in comments. - `nakedret` finds naked returns in functions greater than a specified function length. - `varcheck` finds unused global variables and constants. Our repo was already passing these linters so no fixes needed. Also explicitly list all linters enabled by default, for reference. Part of #217 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
olix0r
approved these changes
Feb 23, 2019
.golangci.yml
Outdated
| # - dupl | ||
| # - gochecknoglobals | ||
| # - gochecknoinits | ||
| # - goconst # TODO |
siggy
force-pushed
the
siggy/varcheck-lint
branch
from
e797963
to
57149e6
Compare
Signed-off-by: Andrew Seigner <siggy@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the following linters:
deadcodefinds unused code.depguardchecks if package imports are in a list of acceptablepackages.
misspellfinds commonly misspelled English words in comments.nakedretfinds naked returns in functions greater than a specifiedfunction length.
varcheckfinds unused global variables and constants.Our repo was already passing these linters so no fixes needed.
Also explicitly list all linters enabled by default, for reference.
Part of #217
Signed-off-by: Andrew Seigner siggy@buoyant.io