Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Enable unparam #2369

Merged
merged 1 commit into from
Feb 27, 2019
Merged

lint: Enable unparam #2369

merged 1 commit into from
Feb 27, 2019

Conversation

siggy
Copy link
Member

@siggy siggy commented Feb 24, 2019

unparam reports unused function parameters:
https://github.com/mvdan/unparam

Part of #217

Signed-off-by: Andrew Seigner siggy@buoyant.io

@siggy siggy self-assigned this Feb 24, 2019
@siggy siggy force-pushed the siggy/unparam-lint branch 2 times, most recently from c322ff5 to f79bd75 Compare February 26, 2019 19:57
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition. Looks great to me 👍

unparam reports unused function parameters:
https://github.com/mvdan/unparam

Part of #217

Signed-off-by: Andrew Seigner <siggy@buoyant.io>
@siggy siggy merged commit 9f748d2 into master Feb 27, 2019
@siggy siggy deleted the siggy/unparam-lint branch February 27, 2019 18:34
Copy link

@rmars rmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🐑 💯 so useful! thanks for adding!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants