Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s 1.16 #3364

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Add support for k8s 1.16 #3364

merged 1 commit into from
Sep 4, 2019

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Sep 3, 2019

Fixes #3356

1.16 removes some api groups that were already deprecated. From k8s blog
post (https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/):

- PodSecurityPolicy: will no longer be served from extensions/v1beta1 in
v1.16.
    Migrate to the policy/v1beta1 API, available since v1.10. Existing
    persisted data can be retrieved/updated via the policy/v1beta1 API.
- DaemonSet, Deployment, StatefulSet, and ReplicaSet: will no longer be
served from extensions/v1beta1, apps/v1beta1, or apps/v1beta2 in v1.16.
    Migrate to the apps/v1 API, available since v1.9. Existing persisted
    data can be retrieved/updated via the apps/v1 API.

Previous PRs had already made this change at the Helm templates level,
but we still needed to do it at the API calls and tests.

The integration tests ran fine for k8s 1.12 and 1.15. They fail on 1.16
because the upgrade integration test tries to install linkerd 2.5 which is not
compatible with 1.16.

@alpeb alpeb self-assigned this Sep 3, 2019
Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending integration tests (if you merge master the previous thrift failure should be gone) 👍 🚢

Fixes #3356

1.16 removes some api groups that were already deprecated. From k8s blog
post (https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/):

```
- PodSecurityPolicy: will no longer be served from extensions/v1beta1 in
v1.16.
    Migrate to the policy/v1beta1 API, available since v1.10. Existing
    persisted data can be retrieved/updated via the policy/v1beta1 API.
- DaemonSet, Deployment, StatefulSet, and ReplicaSet: will no longer be
served from extensions/v1beta1, apps/v1beta1, or apps/v1beta2 in v1.16.
    Migrate to the apps/v1 API, available since v1.9. Existing persisted
    data can be retrieved/updated via the apps/v1 API.
```

Previous PRs had already made this change at the Helm templates level,
but we still needed to do it at the API calls and tests.

The integration tests ran fine for k8s 1.12 and 1.15. They fail on 1.16
because the upgrade integration test tries to install linkerd 2.5 which is not
compatible with 1.16.

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@alpeb alpeb force-pushed the alpeb/apigroups-1.16 branch from 5d09984 to 0c79104 Compare September 4, 2019 14:17
@alpeb alpeb merged commit acbab93 into master Sep 4, 2019
@alpeb alpeb deleted the alpeb/apigroups-1.16 branch September 4, 2019 15:00
alpeb added a commit to linkerd/website that referenced this pull request Sep 11, 2019
Followup to linkerd/linkerd2#3364

Updated API groups for them to work in k8s 1.16

Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
grampelberg pushed a commit to linkerd/website that referenced this pull request Sep 12, 2019
Followup to linkerd/linkerd2#3364

Updated API groups for them to work in k8s 1.16

Signed-off-by: Alejandro Pedraza Borrero <alejandro@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control plane not starting in Kubernetes 1.16
2 participants