-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change square by round brackets in cli usage manual (#3999) #5285
Conversation
@olix0r pipeline fails on integration |
@jiraguha Thanks for the help fixing this issue! I'm assuming that test failure is CI flakiness -- rerunning now to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested fine in my Linux machine, as long as I followed the instructions not under "# zsh" but under "# zsh on osx / oh-my-zsh" (also from looking at cobra's docs, I only see the latter method being mentioned) . @jiraguha would you amend the instructions in linkerd completion
for zsh so we get rid of the former? Thanks!
...By the way, I think we'll submit this as a plugin to oh-my-zsh to make this work out of the box 😉
Signed-off-by: jpiraguha <jiraguha@gmail.com>
@alpeb we should be good now, I followed the same template as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, LGTM 👍
For oh-my-zsh I can open an issue and a PR's for linkerd so we could collaborate to make it work. I would be happy to take the subject :-)
That'd be awesome, thanks!
Are you interested in linkerd swag? Please fill out this form :-)
Signed-off-by: jpiraguha jiraguha@gmail.com
Fixes #3999