Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken table formatting #1681

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix broken table formatting #1681

merged 3 commits into from
Sep 18, 2023

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Sep 14, 2023

close #1672

@mikutas
Fix broken table formatting
f88ce67 
close linkerd#1672

Signed-off-by: Takumi Sue <u630868b@alumni.osaka-u.ac.jp>
@mikutas mikutas marked this pull request as ready for review September 14, 2023 00:26
travisbeckham
travisbeckham approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!

@travisbeckham travisbeckham merged commit 7dd8e1a into linkerd:main Sep 18, 2023
@mikutas mikutas deleted the 1672 branch September 19, 2023 15:00
yohanb pushed a commit to yohanb/linkerd-website that referenced this pull request Sep 21, 2023
@mikutas @travisbeckham @yohanb
Fix broken table formatting (linkerd#1681)
44bf8f8 
close linkerd#1672

Signed-off-by: Takumi Sue <u630868b@alumni.osaka-u.ac.jp>
Co-authored-by: Travis Beckham <57149918+travisbeckham@users.noreply.github.com>
yohanb pushed a commit to yohanb/linkerd-website that referenced this pull request Sep 21, 2023
@mikutas @travisbeckham @yohanb
Fix broken table formatting (linkerd#1681)
bba6597 
close linkerd#1672

Signed-off-by: Takumi Sue <u630868b@alumni.osaka-u.ac.jp>
Co-authored-by: Travis Beckham <57149918+travisbeckham@users.noreply.github.com>
Signed-off-by: Yohan Belval <ybelval@turo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisbeckham travisbeckham travisbeckham approved these changes

@alpeb alpeb Awaiting requested review from alpeb

@kflynn kflynn Awaiting requested review from kflynn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting error on reference/authorization-policy/#targetref
2 participants
@mikutas @travisbeckham