Start review scary rust code from decode_github_content:
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep old `deprecated` function - use normal `fn` args instead of `struct` - avoid long names - add `rustfmt.toml` and deny clippy lints
uselessgoddess
commented
Apr 8, 2023
| pub struct DecodeGithubContentArgument<'a> { | ||
| pub content: &'a String, | ||
| } | ||
|
|
||
| pub fn decode_github_content(argument: &DecodeGithubContentArgument<'_>) -> Option<String> { |
There was a problem hiding this comment.
You don't need to pass struct by ref, it just adds another one ref level for each of its fields:
contentwill be&&String
uselessgoddess
commented
Apr 8, 2023
|
|
||
| #[deprecated] | ||
| pub struct DecodeGithubContentArgument<'a> { | ||
| pub content: &'a String, |
There was a problem hiding this comment.
To pass string as view you have to decide:
- you should pass as
&strif you want only read some data - pass as
Stringif you want to use allocated space in this string
uselessgoddess
commented
Apr 8, 2023
Comment on lines
-9
to
-11
| let DecodeGithubContentArgument { | ||
| content | ||
| } = argument; |
uselessgoddess
commented
Apr 8, 2023
| let mut content_without_github_shit = content.as_bytes().to_owned(); | ||
| content_without_github_shit.retain(|b| !b" \n\t\r\x0b\x0c".contains(b)); | ||
| let decoded_content = base64::engine::general_purpose::STANDARD | ||
| .decode(&content_without_github_shit).unwrap(); |
There was a problem hiding this comment.
Unwrapping it here is bad, this function returns Option.
uselessgoddess
commented
Apr 8, 2023
| content_without_github_shit.retain(|b| !b" \n\t\r\x0b\x0c".contains(b)); | ||
| let decoded_content = base64::engine::general_purpose::STANDARD | ||
| .decode(&content_without_github_shit).unwrap(); | ||
| Some(String::from_utf8_lossy(&decoded_content).into_owned()) |
There was a problem hiding this comment.
base64 always use ASCII chars – String::from_utf8_lossy is unnecessary
There was a problem hiding this comment.
Cow::into_owned also is bad
uselessgoddess
commented
Apr 8, 2023
uselessgoddess
commented
Apr 8, 2023
| extern crate core; | ||
| #![deny(clippy::all, clippy::perf)] // `clippy::perf` will teach you to write good code always | ||
|
|
||
| pub(crate) use anyhow::Result; |
There was a problem hiding this comment.
anyhow::Result supports custom errors, so we can override std::Result by it
|
@FreePhoenix888 where is your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecatedfunctionfnargs instead ofstructrustfmt.tomland deny clippy lints