Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run test not in docker by default #1606

Merged
merged 43 commits into from
May 28, 2024
Merged

feat: run test not in docker by default #1606

merged 43 commits into from
May 28, 2024

Conversation

CasLubbers
Copy link
Contributor

@CasLubbers CasLubbers commented May 3, 2024 •
edited
Loading

Changes made

  • Otomi commands are now default run on local machine instead of Docker
  • Otomi IN_DOCKER command must now be either true or false. If its unset it wil default to false. When it's false it will not run the commands in Docker
  • Otomi tools image is made compatible for multi architecture. Only Gatekeeper stuff in there isn't

@CasLubbers CasLubbers force-pushed the cas-arm branch 23 times, most recently from 728b08d to 6c15d7c Compare May 7, 2024 14:38
@j-zimnowoda j-zimnowoda self-requested a review May 16, 2024 12:05
@j-zimnowoda j-zimnowoda marked this pull request as ready for review May 16, 2024 12:05
j-zimnowoda
j-zimnowoda reviewed May 16, 2024
View reviewed changes
tools/Dockerfile-2 Outdated Show resolved Hide resolved
j-zimnowoda
j-zimnowoda reviewed May 16, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
j-zimnowoda
j-zimnowoda reviewed May 16, 2024
View reviewed changes
tools/Dockerfile Outdated Show resolved Hide resolved
j-zimnowoda
j-zimnowoda reviewed May 16, 2024
View reviewed changes
tools/Dockerfile Outdated Show resolved Hide resolved
@CasLubbers CasLubbers changed the title feat: make dockerfiles multi arch compatible feat: run npm test not in docker by default May 17, 2024
@CasLubbers CasLubbers force-pushed the cas-arm branch 2 times, most recently from 676f1ad to 16f41ba Compare May 21, 2024 06:53
CasLubbers
CasLubbers commented May 21, 2024
View reviewed changes
Dockerfile Show resolved Hide resolved
@CasLubbers CasLubbers changed the title feat: run npm test not in docker by default feat: run test not in docker by default May 21, 2024
@CasLubbers
Copy link
Contributor Author

Building Otomi tools image work: https://github.com/redkubes/otomi-core/actions/runs/9170313333
Building Otomi core image work: https://github.com/redkubes/otomi-core/actions/runs/9174762398/job/25226419553

ferruhcihan
ferruhcihan approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ferruhcihan
ferruhcihan approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works well 👍

@j-zimnowoda j-zimnowoda self-requested a review May 24, 2024 13:29
@j-zimnowoda j-zimnowoda merged commit a94b854 into main May 28, 2024
8 checks passed
@j-zimnowoda j-zimnowoda deleted the cas-arm branch May 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda approved these changes

@ferruhcihan ferruhcihan ferruhcihan approved these changes

@Ani1357 Ani1357 Awaiting requested review from Ani1357

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasLubbers @j-zimnowoda @ferruhcihan