Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removing hashicorp vault and external-secrets #1618

Merged
merged 11 commits into from
Jun 7, 2024
Merged

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented May 30, 2024

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@Ani1357 Ani1357 changed the title feat: removing hashicorp vault feat: removing hashicorp vault and external-secrets May 31, 2024
versions.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vault and external secrets are removed from the UI only the helm charts still exist in the cluster is that correct?
Yes it was correct we can merge it :)

@CasLubbers CasLubbers merged commit dbca465 into main Jun 7, 2024
8 checks passed
@CasLubbers CasLubbers deleted the removing_vault branch June 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants