Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: console prefix #1634

Merged
merged 2 commits into from
Jul 3, 2024
Merged

feat: console prefix #1634

merged 2 commits into from
Jul 3, 2024

Conversation

dennisvankekem
Copy link
Contributor

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

srodenhuis
srodenhuis approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@srodenhuis srodenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srodenhuis srodenhuis merged commit ba34f5d into main Jul 3, 2024
8 checks passed
@srodenhuis srodenhuis deleted the feat-console-prefix branch July 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srodenhuis srodenhuis srodenhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennisvankekem @srodenhuis