Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove aws specif charts #1638

Merged
merged 5 commits into from
Jul 17, 2024
Merged

fix: remove aws specif charts #1638

merged 5 commits into from
Jul 17, 2024

Conversation

srodenhuis
Copy link
Contributor

No description provided.

@srodenhuis srodenhuis marked this pull request as draft July 4, 2024 13:18
@srodenhuis srodenhuis marked this pull request as ready for review July 8, 2024 06:34
j-zimnowoda
j-zimnowoda requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide migrations in the values-change.yaml file

@srodenhuis srodenhuis requested a review from Ani1357 July 16, 2024 09:16
Ani1357
Ani1357 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srodenhuis srodenhuis merged commit 90832ce into main Jul 17, 2024
7 checks passed
@srodenhuis srodenhuis deleted the sr-cleanup-aws branch July 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-zimnowoda j-zimnowoda j-zimnowoda requested changes

@Ani1357 Ani1357 Ani1357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srodenhuis @j-zimnowoda @Ani1357