fix: values changes #1652
Merged
fix: values changes #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merll
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Trying to run this on my test cluster that yesterday failed migrating to main, I get the following error in the pipeline:
in helmfile.d/helmfile-04.databases.yaml: failed to render values files "../values/harbor/harbor-otomi-db.gotmpl": failed to render [../values/harbor/harbor-otomi-db.gotmpl], because of template: stringTemplate:5:13: executing "stringTemplate" at <$v.obj.buckets>: map has no entry for key "buckets"
at hfCore (/home/app/stack/dist/src/common/hf.js:45:30)
exit code: 1
at ChildProcess.<anonymous> (/home/app/stack/node_modules/zx/dist/bundle.cjs:15261:22)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1100:16)
at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
merll
reviewed
Jul 19, 2024
merll
reviewed
Jul 19, 2024
|
@srodenhuis Please take a look at 79c354a, which I have done so I get a functional APL again. I can push the commit on top of this branch if you agree. |
merll
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the value changes required for previous PRs and:
apiNamelegacy