Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove team jobs #1665

Merged
merged 8 commits into from
Aug 12, 2024
Merged

feat: remove team jobs #1665

merged 8 commits into from
Aug 12, 2024

Conversation

j-zimnowoda
Copy link
Contributor

This is an old jobs concept that we have already deprecated long time ago.

ferruhcihan
ferruhcihan previously approved these changes Aug 7, 2024
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-zimnowoda
Copy link
Contributor Author

This cannot be merged because the values migration does not work as expected

@j-zimnowoda j-zimnowoda dismissed ferruhcihan’s stale review August 8, 2024 08:13

This cannot be merged because the values migration does not work as expected

@j-zimnowoda
Copy link
Contributor Author

Added functionality to remove files and tested on cluster:
image

From the screenshot you can see that after values migration the jobs related files are removed

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a cluster, LGTM

@j-zimnowoda j-zimnowoda merged commit 142837d into main Aug 12, 2024
7 checks passed
@j-zimnowoda j-zimnowoda deleted the remove-team-jobs branch August 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants