Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket only linode #1703

Merged
merged 6 commits into from
Sep 6, 2024
Merged

fix: bucket only linode #1703

merged 6 commits into from
Sep 6, 2024

Conversation

srodenhuis
Copy link
Contributor

Buckets can only be set when the OBJ provider is Linode. When using Minio, all buckets are pre-provisioned and bucket names can not be changed.

@j-zimnowoda
Copy link
Contributor

j-zimnowoda commented Sep 3, 2024

Does this PR have a corresponding apl-api PR?

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing values migrations

@srodenhuis
Copy link
Contributor Author

corresponding PR for API: https://github.com/linode/apl-api/pull/546

@j-zimnowoda
Copy link
Contributor

j-zimnowoda commented Sep 6, 2024

Migration goes well
image
but there is templating issue

# binzx/otomi template -l name=harbor-otomi-db   
 otomi:common:prepareEnvironment:info Checking environment +0ms
 otomi:common:crypt:decrypt:info Skipping decryption +0ms
 otomi:cmd:template:template:info # Templating STARTED +0ms
WARNING: release knative-serving-artifacts needs knative-operator, but knative-operator is not installed due to installed: false. Either mark knative-operator as installed or remove knative-operator from knative-serving-artifacts's needs
in helmfile.d/helmfile-04.databases.yaml: failed to render values files "../values/harbor/harbor-otomi-db.gotmpl": failed to render [../values/harbor/harbor-otomi-db.gotmpl], because of template: stringTemplate:25:34: executing "stringTemplate" at <$obj.linode.buckets.cnpg>: map has no entry for key "buckets"
 otomi:global:error Error: WARNING: release knative-serving-artifacts needs knative-operator, but knative-operator is not installed due to installed: false. Either mark knative-operator as installed or remove knative-operator from knative-serving-artifacts's needs
 otomi:global:error in helmfile.d/helmfile-04.databases.yaml: failed to render values files "../values/harbor/harbor-otomi-db.gotmpl": failed to render [../values/harbor/harbor-otomi-db.gotmpl], because of template: stringTemplate:25:34: executing "stringTemplate" at <$obj.linode.buckets.cnpg>: map has no entry for key "buckets"
 otomi:global:error     at hfCore (/Users/jzimnowo/workspace/linode/apl-core/src/common/hf.ts:55:17)
 otomi:global:error     exit code: 1
 otomi:global:error     at ChildProcess.<anonymous> (/Users/jzimnowo/workspace/linode/apl-core/node_modules/zx/dist/bundle.cjs:15261:22)
 otomi:global:error     at ChildProcess.emit (node:events:517:28)
 otomi:global:error     at ChildProcess.emit (node:domain:489:12)
 otomi:global:error     at maybeClose (node:internal/child_process:1098:16)
 otomi:global:error     at Socket.<anonymous> (node:internal/child_process:450:11)
 otomi:global:error     at Socket.emit (node:events:517:28)
 otomi:global:error     at Socket.emit (node:domain:489:12)
 otomi:global:error     at Pipe.<anonymous> (node:net:350:12) +0ms
# binzx/otomi template -l name=gitea-otomi-db
 otomi:common:prepareEnvironment:info Checking environment +0ms
 otomi:common:crypt:decrypt:info Skipping decryption +0ms
 otomi:cmd:template:template:info # Templating STARTED +0ms
WARNING: release knative-serving-artifacts needs knative-operator, but knative-operator is not installed due to installed: false. Either mark knative-operator as installed or remove knative-operator from knative-serving-artifacts's needs
in helmfile.d/helmfile-04.databases.yaml: failed to render values files "../values/gitea/gitea-otomi-db.gotmpl": failed to render [../values/gitea/gitea-otomi-db.gotmpl], because of template: stringTemplate:26:34: executing "stringTemplate" at <$obj.linode.buckets.cnpg>: map has no entry for key "buckets"
 otomi:global:error Error: WARNING: release knative-serving-artifacts needs knative-operator, but knative-operator is not installed due to installed: false. Either mark knative-operator as installed or remove knative-operator from knative-serving-artifacts's needs
 otomi:global:error in helmfile.d/helmfile-04.databases.yaml: failed to render values files "../values/gitea/gitea-otomi-db.gotmpl": failed to render [../values/gitea/gitea-otomi-db.gotmpl], because of template: stringTemplate:26:34: executing "stringTemplate" at <$obj.linode.buckets.cnpg>: map has no entry for key "buckets"
 otomi:global:error     at hfCore (/Users/jzimnowo/workspace/linode/apl-core/src/common/hf.ts:55:17)
 otomi:global:error     exit code: 1
 otomi:global:error     at ChildProcess.<anonymous> (/Users/jzimnowo/workspace/linode/apl-core/node_modules/zx/dist/bundle.cjs:15261:22)
 otomi:global:error     at ChildProcess.emit (node:events:517:28)
 otomi:global:error     at ChildProcess.emit (node:domain:489:12)
 otomi:global:error     at maybeClose (node:internal/child_process:1098:16)
 otomi:global:error     at Socket.<anonymous> (node:internal/child_process:450:11)
 otomi:global:error     at Socket.emit (node:events:517:28)
 otomi:global:error     at Socket.emit (node:domain:489:12)
 otomi:global:error     at Pipe.<anonymous> (node:net:350:12) +0ms

@j-zimnowoda j-zimnowoda self-requested a review September 6, 2024 14:55
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed dev cluster manually

@j-zimnowoda j-zimnowoda merged commit 6ace30c into main Sep 6, 2024
2 checks passed
@j-zimnowoda j-zimnowoda deleted the sr-fix-obj-providers branch September 6, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants