-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for elevation, alias border-radius token, launch button tokens #61
Conversation
Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Default border raduis alias token
Launch button will be connected to global tokens, since we're still investigating if this button will be used in the CDS 2.0. Dark mode styles are not defined yet |
…okens structure update
… Progress Bar components that use gradients
We're running into an issue parsing the linear gradient. I need to look into this https://github.com/linode/design-language-system/pull/61/files#diff-342f83c57db10e0bec303f072c2b93b04ddade6fc4ba656e182e07dd2cf9202fR770 |
tokens/alias/light.json
Outdated
@@ -1435,6 +1445,13 @@ | |||
"type": "color" | |||
} | |||
} | |||
}, | |||
"borderRadius": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davyd-akamai We can't have this be the same name as the global token. Maybe we rename this radius
? Or can we just put this under border.borderRadius
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it under border
, but let's talk about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose "border" will not work, since in a Tokens Studio this property is for a border-width (as far as I remember). But let's talk about it
@jaalah-akamai Here will be one more breaking change to a stepper component. UIE team is aware of it. |
New alias accent disabled token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* fix: expand composite objects and convert rem to px (#55) Co-authored-by: Davyd Melkon <131438868+davyd-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * Shadow blur value fix * Launch button tokens Default border raduis alias token * Launch split menu button tokens * New "rangeHover" and "activeDateHover" interaction tokens, calendar tokens structure update * New global gradient token and new component tokens for the Appbar and Progress Bar components that use gradients * Add descriptions * Remove extensions from linear gradient * Update branch with latest and fix border radius and linear gradient * Numeric spinner text color property fix * Horizontal stepper structure update Error tag new background token * New tokens for KPI bar: background token, disabled state for KPIs New alias accent disabled token * Update BorderRadius to Radius * Update BorderRadius to Radius --------- Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Change Summary
Breaking Changes
background
tokens for improved consistency and flexibilitytoken-component-calendar-selected-item-background-default
token-component-calendar-selected-item-background-hover
New Features
inProgress
token for ProgressBar componenttopGradient
token for Appbar componentrangeHover
for date range selectionactiveDateHover
for active date hover statesborderRadius
alias token for unified stylingEnhancements