Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add slack notifications to CI workflow #585

Merged

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Sep 26, 2024

📝 Description

  • Adding slack notifications to CI workflow
  • Secrets required for the step including slack auth token and channel id are added as secrets

e.g.
image

✔️ How to Test

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Sep 26, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner September 26, 2024 22:01
@ykim-akamai ykim-akamai requested review from jriddle-linode and yec-akamai and removed request for a team September 26, 2024 22:01
@ykim-akamai
Copy link
Contributor Author

ykim-akamai commented Sep 26, 2024

https://github.com/linode/linodego/actions/runs/11060897777, failing because repository secrets aren't shared with other forked branches

Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ykim-akamai ykim-akamai merged commit 2b51d5c into linode:main Sep 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants